-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Adding Embedding Apps Functionality #18566
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
app/server/appsmith-server/src/main/java/com/appsmith/server/domains/Application.java
Outdated
Show resolved
Hide resolved
/ok-to-test sha=7934ec3dfe0be9a8ea4d2c4ef3828c0b0fa6e0ae |
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3591903489. |
/ok-to-test sha=6580480614573558a6e41e61c9b8225c0aa476b8 |
1 similar comment
/ok-to-test sha=6580480614573558a6e41e61c9b8225c0aa476b8 |
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3600707958. |
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3601171453. |
/ok-to-test sha=26abea8e0bf267c5fbb6e6f74d7395b99ce6adc2 |
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3614355555. |
* replace BlackAuthCardNavLink with Link from design system * Replace AuthCardNavLink with Link from design system * Refactor ForgotPasswordLink to use Link from design-system * use variables from ads * replace FooterLinks with Link * bump design-system alpha version * fix issue with Segment header props * Add font size for ForgotPassword explicitly * bump alpha version * Make "Sign In" text primary as well * Update ds alpha version * use TextType in location * use typography constants from design-system * update alpha version * bump design-system version * Empty-Commit * use correct typographic variables * fix: Form message component link issue * removed the inverted flag for testing * Update to use correct variable * Change floatingBtn in DefaultTheme file * fix: Made changes to pass action link element to design system component - formMessage * chore: update design-system version to fix issue with radio * Remove unnecessary imports * fix Merge_spec.js cypress test * fixed conflict with react router Link and design system Link * chore: dependentbot vulnerabilities. (#18528) * fix: dependentbot vulnerabilities. * chore: remove emoji-mart. * chore: updated react-syntax-highlighter * chore: update ts-loader add loader-utils resolution. Co-authored-by: Aishwarya UR <[email protected]> * fix: Added support for country code flags on windows devices (#18203) * fix: add pollyfill and use font family. * fix: use latest version design system. Co-authored-by: Aishwarya UR <[email protected]> * fix: Updating spec for member roles (#18657) updated spec for member roles * feat: [Context Switching] Maintain datasource collapse state (#17616) * chore: Remove debugging logs for analytics (#18662) * chore: Support using custom port(s) for listening in the start-https.sh script (#18451) Added `--https-port` and `--http-port`, so you can set a custom port instead of the default 80 and 443. This is useful if you want to test Appsmith when using a non-standard port, fox example, how `appsmith.URL.host` behaves, or how OAuth redirects behave etc. We also add a shortcut to start this with release endpoint. Just using `release` is now the same thing as using `https://release.app.appsmith.com`. This is useful to people like me who are _very_ good with typos. * feat: Adding Embedding Apps Functionality in the API (#18566) * chore: fix ingress fieldname in appsmith (#18684) * fix: Auto height breaks for fixed modal's children (#18691) Fix issue where auto height was throwing an error when a fixed modal widget's children were changing height automatically * fix: datasource autosave git issue fixed (#18690) * datasource autosave git issue fixed * Added appropriate comments Co-authored-by: “sneha122” <“[email protected]”> * chore: Improved metadata on logs when reading DSL fails (#18692) * chore: Improved metadata on logs when reading DSL fails * Fixed test * Test fix * Review comment * Update top contributors * chore: bump ds version to use better MenuDivider type Co-authored-by: Albin <[email protected]> Co-authored-by: Parthvi Goswami <[email protected]> Co-authored-by: Arsalan Yaldram <[email protected]> Co-authored-by: Aishwarya UR <[email protected]> Co-authored-by: Ankita Kinger <[email protected]> Co-authored-by: akash-codemonk <[email protected]> Co-authored-by: Anagh Hegde <[email protected]> Co-authored-by: Shrikant Sharat Kandula <[email protected]> Co-authored-by: Nilansh Bansal <[email protected]> Co-authored-by: Goutham Pratapa <[email protected]> Co-authored-by: Abhinav Jha <[email protected]> Co-authored-by: sneha122 <[email protected]> Co-authored-by: “sneha122” <“[email protected]”> Co-authored-by: Nidhi <[email protected]> Co-authored-by: Appsmith Bot <[email protected]>
Warning Rate limit exceeded@Nikhil-Nandagopal has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 29 minutes and 55 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
Description
This PR implements the functionality for Embedding Appsmith apps into any other platform.
It reuses the following existing APIs:
An additional field
embedSetting
has been added to theapplication
collection.Fixes #18292
Job stories
Type of change
How Has This Been Tested?
Testing Results
Update EmbedSetting API
GET EmbedSetting API
Checklist:
Dev activity
QA activity: